Add options to set the source of the ssl certs#258
Merged
austb merged 0 commit intopuppetlabs:masterfrom Nov 5, 2020
Merged
Conversation
Author
|
The master branch of the apt module is breaking on puppet 3, with a syntax error. |
edestecd
force-pushed
the
master
branch
4 times, most recently
from
15bd33c to
3a54988
Compare
Author
|
Also pinned modules in fixtures until this module depreciates puppet 3. This gets the tests passing again... |
Contributor
|
Well, this PR was a long time ago, wasn't it. Sorry about the very, very long delay. Basically it looks good to me, but it needs tests. Can you add them and rebase onto master? Shouldn't need the module pinning anymore either. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add a convenient boolean to copy over the certs from the puppet cert directory.