(FM-2713) Remove sqlserver::config file requirement#106
Merged
ferventcoder merged 3 commits intopuppetlabs:masterfrom May 19, 2015
cyberious:FM-2713
Merged
(FM-2713) Remove sqlserver::config file requirement#106ferventcoder merged 3 commits intopuppetlabs:masterfrom cyberious:FM-2713
ferventcoder merged 3 commits intopuppetlabs:masterfrom
cyberious:FM-2713
Conversation
added 3 commits
May 18, 2015 10:09
This enhancement is to remove storing the admin_user and admin_pass on disk Instead, find the Sqlserver::Config defined within the current catalog and the credentials declared there.
- Since removing the file requirement we no longer need to depend on acl
- Add rescue to ensure we catch any connection issues with open
Contributor
|
Argh, GitHub caching problems - was showing me old content. |
Contributor
|
So if I understand this correctly - the credentials are now ONLY in the manifest. |
Contributor
|
If so, 👍 |
Contributor
rob@skylight:~/code/puppetlabs/modules/puppetlabs-sqlserver [(6fd7279...)] 11:25:50 $ bundle exec rake lint
manifests/login/permissions.pp - WARNING: double quoted string containing no variables on line 44
manifests/user/permissions.pp - WARNING: double quoted string containing no variables on line 57
manifests/user/permissions.pp - WARNING: double quoted string containing no variables on line 62 |
Contributor
Author
There was a problem hiding this comment.
Well yeah... fozy bear
Contributor
Author
|
#109 to address lint and strict variables |
Contributor
There was a problem hiding this comment.
Okay, this it the one I'm lost on. I don't see where this would ever be set.
Contributor
There was a problem hiding this comment.
And no tests set it either.
Contributor
Author
There was a problem hiding this comment.
Future enhancement
ferventcoder
added a commit
that referenced
this pull request
May 19, 2015
(FM-2713) Remove sqlserver::config file requirement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.