[MODULES-4255] Obfuscate passwords in sqlserver_instance#195
Merged
ferventcoder merged 1 commit intopuppetlabs:masterfrom Jan 24, 2017
wilson208:obfuscate-password
Merged
[MODULES-4255] Obfuscate passwords in sqlserver_instance#195ferventcoder merged 1 commit intopuppetlabs:masterfrom wilson208:obfuscate-password
ferventcoder merged 1 commit intopuppetlabs:masterfrom
wilson208:obfuscate-password
Conversation
| format_cmd_args_array('/ASSYSADMINACCOUNTS', @resource[:as_sysadmin_accounts], cmd_args) | ||
| end | ||
| cmd_args | ||
| return cmd_args, obfuscated_strings |
Contributor
There was a problem hiding this comment.
Won't this still return the password in plaintext?
Contributor
|
Perhaps we yank Puppet v3 from this list? |
Contributor
Author
|
@ferventcoder Will rebase these changes on top of master when hunter is finished his modulesync that should remove appveyor on spec tests running on puppet 3 and work out gem issues. |
When errors are logged after setup.exe fails to run
Contributor
Author
|
@ferventcoder this is now passing, I rebased these changes on top of the latest modulesync run which removed puppet 3 from the unit test matrix on appveyor. |
Contributor
|
Awesome. I'd like to run this through the ad hoc before pulling it in if you don't mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When errors are logged after setup.exe fails to run