(FM-5389) Fix sql_features when installing SNAC_SDK#219
Merged
jpogran merged 3 commits intopuppetlabs:masterfrom Jun 21, 2017
glennsarti:fix-snac
Merged
(FM-5389) Fix sql_features when installing SNAC_SDK#219jpogran merged 3 commits intopuppetlabs:masterfrom glennsarti:fix-snac
jpogran merged 3 commits intopuppetlabs:masterfrom
glennsarti:fix-snac
Conversation
Previously the sql_features was not idempotent when installing the SQL Native Client SDK (SNAC_SDK). This Due to the SQL Native Client not being unique across SQL Server versions (e.g. SQL 2016 (v13) installs Native Client with a version that matches for SQL 2012 (v11)). Due to MODULES-5060 it is noted that the SQL Server Module can not be used to manage different SQL Server versions on the same host. Knowing this it is safe to collate all of the SQL Server shared features, regardless of version, and use that as the list of installed features and is safely idempotent. This commit also adds a README section to known issues about this issue.
This reverts commit d26c1df.
The SNAC_SDK feature can not be managed by the module as it is not able to be uninstalled using the SQL Server installation media (particularly on SQL Server 2016). This commit adds a note about this limitation in the README.
Contributor
Author
|
adhoc acceptance tests have passed. This is ready for merge. |
glennsarti
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the sql_features was not idempotent when installing the SQL Native
Client SDK (SNAC_SDK). This Due to the SQL Native Client not being unique
across SQL Server versions (e.g. SQL 2016 (v13) installs Native Client with a
version that matches for SQL 2012 (v11)). Due to MODULES-5060 it is noted that
the SQL Server Module can not be used to manage different SQL Server versions
on the same host. Knowing this it is safe to collate all of the SQL Server
shared features, regardless of version, and use that as the list of installed
features and is safely idempotent.
This commit also adds a README section to known issues about this issue.