(FM-5021) Escaping identifiers when creating a database#222
Merged
jpogran merged 1 commit intopuppetlabs:masterfrom Jun 23, 2017
glennsarti:fm-5021-escape-db-names
Merged
(FM-5021) Escaping identifiers when creating a database#222jpogran merged 1 commit intopuppetlabs:masterfrom glennsarti:fm-5021-escape-db-names
jpogran merged 1 commit intopuppetlabs:masterfrom
glennsarti:fm-5021-escape-db-names
Conversation
Previously the name of file and log files were not escaped properly which caused SQL Server to interpret incorrectly. The dashes in the name were being seen as a minus operator. This commit changes the name of the Log and File files to be seen as strings instead of identifiers. This commit also updates the spec tests to expect these names to be escaped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the name of file and log files were not escaped properly which caused
SQL Server to interpret incorrectly. The dashes in the name were being seen as
a minus operator. This commit changes the name of the Log and File files to be
seen as strings instead of identifiers. This commit also updates the spec tests
to expect these names to be escaped.