(maint) Remove instance during acceptance tests#242
Merged
ThoughtCrhyme merged 1 commit intopuppetlabs:masterfrom Oct 16, 2017
glennsarti:fix-acceptance-test
Merged
(maint) Remove instance during acceptance tests#242ThoughtCrhyme merged 1 commit intopuppetlabs:masterfrom glennsarti:fix-acceptance-test
ThoughtCrhyme merged 1 commit intopuppetlabs:masterfrom
glennsarti:fix-acceptance-test
Conversation
Previously during the sqlserver_config acceptance tests multiple database instances were being created, instead of destroyed, for example a datbase instance of 'abseny' was being created. This commit fixes this test fixture failure by calling the ensure_sqlserver_instance helper method with the correct parameters to remove an instance.
ThoughtCrhyme
approved these changes
Oct 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously during the sqlserver_config acceptance tests multiple database
instances were being created, instead of destroyed, for example a datbase
instance of 'abseny' was being created. This commit fixes this test fixture
failure by calling the ensure_sqlserver_instance helper method with the correct
parameters to remove an instance.