(MODULES-6168) Detect SQL 2017#251
Merged
jpogran merged 1 commit intopuppetlabs:masterfrom Dec 6, 2017
Merged
Conversation
This change updates the features.rb file to ensure that it is checking for the registry keys for SQL 2017.
Contributor
michaeltlombardi
left a comment
michaeltlombardi
left a comment
There was a problem hiding this comment.
This is off to a good start, but I think we'll need to make sure we add handling to testing for 2017 before we pull in (otherwise our only validation is manual).
Contributor
Author
|
Manual verification of changes to be completed. |
michaeltlombardi
approved these changes
Dec 4, 2017
Contributor
Author
|
I manually verified these changes by running puppet manifests that install SQL 2017 instances both alone and alongside down version instances. The module will also manage 2017 instances and existing features (no new features added for 2017), without incorrectly managing the other instances' features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the features.rb file to ensure that it is checking for the registry keys for SQL 2017.