Skip to content

(MAINT) Fix changelog.#287

Merged
michaeltlombardi merged 1 commit intopuppetlabs:masterfrom
RandomNoun7:maint/master/update-changelog-for-bug-fix
Jan 16, 2019
Merged

(MAINT) Fix changelog.#287
michaeltlombardi merged 1 commit intopuppetlabs:masterfrom
RandomNoun7:maint/master/update-changelog-for-bug-fix

Conversation

@RandomNoun7
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread CHANGELOG.md Outdated

- Add support for installing and managing SQL 2019 instances ([MODULES-8438](https://tickets.puppetlabs.com/browse/MODULES-8438))

###
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing title Fixed

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh

@RandomNoun7 RandomNoun7 force-pushed the maint/master/update-changelog-for-bug-fix branch from 89925dd to f7d7ac6 Compare January 16, 2019 16:30
@michaeltlombardi michaeltlombardi dismissed their stale review January 16, 2019 16:34

Noticed commit message formatting.

@michaeltlombardi
Copy link
Copy Markdown
Contributor

Happy to approve and merge if you can update the commit message to start with (MAINT). 😄

@RandomNoun7 RandomNoun7 force-pushed the maint/master/update-changelog-for-bug-fix branch from f7d7ac6 to 71fb81f Compare January 16, 2019 16:35
@michaeltlombardi michaeltlombardi changed the title Fix changelog. (MAINT) Fix changelog. Jan 16, 2019
@michaeltlombardi michaeltlombardi merged commit d31ecce into puppetlabs:master Jan 16, 2019
@RandomNoun7 RandomNoun7 deleted the maint/master/update-changelog-for-bug-fix branch January 16, 2019 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants