(MODULES-8749) Make job_name param required.#303
Merged
jpogran merged 1 commit intopuppetlabs:masterfrom Mar 19, 2019
Merged
Conversation
Prior to this change, even though the job_name param is defined as required by the PowerShell script that powers the task, the json file that describes the task defines that parameter to Bolt as Optional. This causes the task to hang if the task is invoked with no job_name parameter. This change updates the json so that Bolt understands the param is required, and removes an unnecessary conditional check to to ensure the paramter is present, as both platforms already ensure it. The else block in that check also had code that should never run in this task.
jpogran
approved these changes
Mar 19, 2019
RandomNoun7
deleted the
tickets/master/MODULES-8749-make-job_name-required
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, even though the job_name param is defined as
required by the PowerShell script that powers the task, the json file
that describes the task defines that parameter to Bolt as Optional.
This causes the task to hang if the task is invoked with no job_name
parameter. This change updates the json so that Bolt understands the
param is required, and removes an unnecessary conditional check to
to ensure the paramter is present, as both platforms already ensure
it. The else block in that check also had code that should never run
in this task.