(FM-8879) Handle T-SQL Errors Properly#349
Merged
sanfrancrisko merged 1 commit intopuppetlabs:masterfrom Apr 28, 2020
Merged
Conversation
RandomNoun7
force-pushed
the
tickets/FM-8879-handle-t-sql-errors
branch
4 times, most recently
from
e9daf11 to
4ea829d
Compare
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
=========================================
Coverage ? 56.25%
=========================================
Files ? 20
Lines ? 759
Branches ? 0
=========================================
Hits ? 427
Misses ? 332
Partials ? 0
Continue to review full report at Codecov.
|
The previous commit that improved T-SQL error handling was incomplete. That commit (9b8a0fe) was not able to overcome an important issue. The issue was that if there was a successfull row insert into a table the `Errors` collection of the ADODB.Connection would be empty, even if an error was deliberately thrown using the `THROW` keyword. It turns out that the successfull row insert was causing a text return value, and it's a known issue that if values are returned to the object that the Errors collection will be empty. We know now that turning `SET NOCOUNT ON` in the beginning of the query will suppress that text status message and allow more errors to be properly detected in the ADODB.Connect object, and handled properly in the module's `onlyif` clause.
RandomNoun7
force-pushed
the
tickets/FM-8879-handle-t-sql-errors
branch
from
4ea829d to
d741bd7
Compare
sanfrancrisko
approved these changes
Apr 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous commit that improved T-SQL error handling was incomplete.
That commit (9b8a0fe) was not able to
overcome an important issue.
The issue was that if there was a successfull row insert into a table
the
Errorscollection of the ADODB.Connection would be empty, evenif an error was deliberately thrown using the
THROWkeyword.It turns out that the successfull row insert was causing a text return
value, and it's a known issue that if values are returned to the object
that the Errors collection will be empty.
We know now that turning
SET NOCOUNT ONin the beginning of the querywill suppress that text status message and allow more errors to be
properly detected in the ADODB.Connect object, and handled properly
in the module's
onlyifclause.