Skip to content

(MODULES-5472) Login values can now be passed as sensitive strings#393

Merged
adrianiurca merged 2 commits intopuppetlabs:mainfrom
david22swan:MODULES-5472/main/sensitive_passwords
Sep 23, 2021
Merged

(MODULES-5472) Login values can now be passed as sensitive strings#393
adrianiurca merged 2 commits intopuppetlabs:mainfrom
david22swan:MODULES-5472/main/sensitive_passwords

Conversation

@david22swan
Copy link
Copy Markdown
Member

admin_user, admin_pass and password can now be passed as sensitive strings in order to prevent them from being leaked within the logs.

admin_user, admin_pass and password can now be passed as sensitive strings in order to prevent them from being leaked within the logs.
@david22swan david22swan requested a review from a team as a code owner September 10, 2021 12:20
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 10, 2021

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link
Copy Markdown

sqlserver::config is a type

that may have no external impact to Forge modules.

sqlserver::login is a type

that may have no external impact to Forge modules.

This module is declared in 3 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Have updated several test's throughout the codebase to use the new sensitive value for admin_user, admin_pass and password as proof of concept.
@adrianiurca adrianiurca merged commit 76a235f into puppetlabs:main Sep 23, 2021
@david22swan david22swan deleted the MODULES-5472/main/sensitive_passwords branch April 26, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants