Skip to content

FM-1556 Add ability to manage login server level permissions#72

Merged
Iristyle merged 2 commits intopuppetlabs:masterfrom
cyberious:FM-1556
Feb 27, 2015
Merged

FM-1556 Add ability to manage login server level permissions#72
Iristyle merged 2 commits intopuppetlabs:masterfrom
cyberious:FM-1556

Conversation

@cyberious
Copy link
Copy Markdown
Contributor

No description provided.

@cyberious cyberious changed the title FM-1556 Add ability to manage login server level permissions DO NOT MERGE~~~ FM-1556 Add ability to manage login server level permissions Feb 23, 2015
@cyberious cyberious changed the title DO NOT MERGE~~~ FM-1556 Add ability to manage login server level permissions FM-1556 Add ability to manage login server level permissions Feb 23, 2015
@cyberious
Copy link
Copy Markdown
Contributor Author

Thought there was a bug, was not, it was an issue with test login having svrroles that caused failure.

Comment thread manifests/login/permission.pp Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit - bad grammar

@Iristyle
Copy link
Copy Markdown
Contributor

Added a note to the ticket about getting a capture of successful manifest runs against SQL Server since there are no acceptance tests.

Comment thread manifests/login/permission.pp Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about EXECUTE? Nevermind, these are examples.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update documentation - this is permissions now.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still not updated.

@ferventcoder
Copy link
Copy Markdown
Contributor

Nothing really jumps out at me as inherently bad here. Just small tweaks and of course the CASCADE thing.

@cyberious
Copy link
Copy Markdown
Contributor Author

@Iristyle added comments to ticket FM-1556 in regards to the testing of the code

@cyberious
Copy link
Copy Markdown
Contributor Author

Requires #74 for tests to pass

@cyberious
Copy link
Copy Markdown
Contributor Author

@ferventcoder @Iristyle Here is the latest, I modified last night to be able to pass an array of permissions instead of individual ones. This applies to both Login and User permissions.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment from #71 about the double loop.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to single loop

@ferventcoder
Copy link
Copy Markdown
Contributor

Same deal here with documentation. Get that updated and this is :shipit:

@cyberious
Copy link
Copy Markdown
Contributor Author

@ferventcoder docs updated

@Iristyle Iristyle merged commit 12de69b into puppetlabs:master Feb 27, 2015
@Iristyle Iristyle deleted the FM-1556 branch February 27, 2015 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants