Skip to content

FM-2287 Add Role Permissions ability#76

Merged
hunner merged 5 commits intopuppetlabs:masterfrom
cyberious:RolePermissions
Mar 3, 2015
Merged

FM-2287 Add Role Permissions ability#76
hunner merged 5 commits intopuppetlabs:masterfrom
cyberious:RolePermissions

Conversation

@cyberious
Copy link
Copy Markdown
Contributor

No description provided.

@underscorgan
Copy link
Copy Markdown
Contributor

still working through review, but missing README updates

Comment thread manifests/role.pp Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be prefixed with a _ since it's a local variable.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still upcase

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple string, stdlib should work fine

hunner added a commit that referenced this pull request Mar 3, 2015
FM-2287 Add Role Permissions ability
@hunner hunner merged commit 3e921d1 into puppetlabs:master Mar 3, 2015
@cyberious cyberious deleted the RolePermissions branch March 3, 2015 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants