Add correct namespace for start_with function#1095
Merged
sanfrancrisko merged 1 commit intopuppetlabs:masterfrom Mar 5, 2020
Merged
Add correct namespace for start_with function#1095sanfrancrisko merged 1 commit intopuppetlabs:masterfrom
sanfrancrisko merged 1 commit intopuppetlabs:masterfrom
Conversation
This function was originally introduced in puppetlabs#1086 but never got a decision about the correct namespace. This commit adds the stdlib:: namespace to the start_with function after a discussion I had with Daneel on Slack about this. This will at least align the namespace with the corresponding end_with function to not confuse people.
Codecov Report
@@ Coverage Diff @@
## master #1095 +/- ##
=========================================
+ Coverage 3.74% 4.64% +0.89%
=========================================
Files 186 186
Lines 5338 5338
=========================================
+ Hits 200 248 +48
+ Misses 5138 5090 -48
Continue to review full report at Codecov.
|
Contributor
|
Thanks for the tweak @baurmatt ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function was originally introduced in #1086 but never got a
decision about the correct namespace. This commit adds the stdlib::
namespace to the start_with function after a discussion I had with
Daneel on Slack about this. This will at least align the namespace with
the corresponding end_with function to not confuse people.
I'm not considering this a breaking change because the function was never released.