[IAC-547] Remove strftime from stdlib as it has already been replaced by the puppet agent since 4.8.0#1097
Merged
michaeltlombardi merged 2 commits intopuppetlabs:masterfrom Mar 9, 2020
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1097 +/- ##
=========================================
+ Coverage 3.74% 4.71% +0.96%
=========================================
Files 186 185 -1
Lines 5338 5258 -80
=========================================
+ Hits 200 248 +48
+ Misses 5138 5010 -128
Continue to review full report at Codecov.
|
michaeltlombardi
approved these changes
Mar 9, 2020
Contributor
|
Marking this as a maintenance commit as the function is already overridden by the function within Puppet, meaning this is not a backwards breaking change. |
Contributor
|
Relabelled and retitled as bugfix so it shows up on the changelog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing strftime as it was already superseded by https://github.com/puppetlabs/puppet/blob/master/lib/puppet/functions/strftime.rb