(bugfix) Setting stricter email validation#1163
Merged
DavidS merged 1 commit intopuppetlabs:mainfrom Feb 10, 2021
Merged
Conversation
pmcmaw
force-pushed
the
test_emails
branch
2 times, most recently
from
e87a34d to
65e3cf3
Compare
Merged
Contributor
|
This looks great! Thanks for going the extra mile for this! |
Contributor
Author
|
@pegasd Not a problem at all, thank you for highlighting. |
DavidS
approved these changes
Feb 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting stricter email validation. Currently this type allows for new lines.
This fix is in relation to the following comment: #1160 (comment)
Thank you for bringing this to our attention @pegasd 👍