(MAINT) Remove testing logic for Puppet 4.5#1193
Merged
michaeltlombardi merged 2 commits intopuppetlabs:mainfrom Jul 12, 2021
Merged
(MAINT) Remove testing logic for Puppet 4.5#1193michaeltlombardi merged 2 commits intopuppetlabs:mainfrom
michaeltlombardi merged 2 commits intopuppetlabs:mainfrom
Conversation
This PR creates new new resources: * Stdlib::Http::Method for validating http methods * Stdlib::Http::Status This is just a copy of Stdlib::Httpstatus * make Stdlib::Httpstatus and alias to Stdlib::Http::Status Ideally we would deprecate Stdlib::Httpstatus in favour of Stdlib::Http::Status
Collaborator
Author
good catch that was over-site should be removed now |
ekohl
requested changes
Jul 6, 2021
| require 'spec_helper' | ||
|
|
||
| if Puppet::Util::Package.versioncmp(Puppet.version, '4.5.0') >= 0 | ||
| describe 'Stdlib::IP::Address::V6::Nosubnet::Full' do |
Collaborator
There was a problem hiding this comment.
I think this line should not have been removed
Support for puppet 4.5 was dropped from stdlib some time ago however the spec tests all include an if guard to prevent them running on puppet 4.5. As this is no longer required this PR cleans up theses guards
ekohl
approved these changes
Jul 6, 2021
Collaborator
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
I'll let others take a look as well.
michaeltlombardi
changed the title
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for puppet 4.5 was dropped from stdlib some time ago however the
spec tests all include an if guard to prevent them running on puppet
4.5. As this is no longer required this PR cleans up theses guards