Skip to content

Added to_toml function#1209

Merged
carabasdaniel merged 1 commit intopuppetlabs:mainfrom
nmaludy:feature/to-toml
Sep 13, 2021
Merged

Added to_toml function#1209
carabasdaniel merged 1 commit intopuppetlabs:mainfrom
nmaludy:feature/to-toml

Conversation

@nmaludy
Copy link
Copy Markdown
Contributor

@nmaludy nmaludy commented Sep 9, 2021

This adds a function to stdlib for converting Puppet hashes to TOML. This is useful for Go services like Telegraf and Gitlab CI Runner than use TOML as their config format. Having this as a common function alleviates the problem of trying to load the toml-rb gem before running catalogs (chicken before the egg problem).

@nmaludy nmaludy requested a review from a team as a code owner September 9, 2021 18:34
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 9, 2021

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link
Copy Markdown

to_toml is a function

that may have no external impact to Forge modules.

This module is declared in 318 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@carabasdaniel
Copy link
Copy Markdown
Contributor

Hi @nmaludy, thank you for your contribution as always. This looks great 👍

@carabasdaniel carabasdaniel merged commit 21132c8 into puppetlabs:main Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants