Add xml_encode function#1236
Merged
david22swan merged 1 commit intopuppetlabs:mainfrom May 16, 2022
Merged
Conversation
Example for unit test taken from https://stackoverflow.com/questions/1443816/convert-an-arbitrary-string-to-xml-in-ruby
stdlib::xml_encode is a functionthat may have no external impact to Forge modules. This module is declared in 318 of 579 indexed public
|
bastelfreak
approved these changes
Apr 26, 2022
david22swan
approved these changes
May 16, 2022
Member
david22swan
left a comment
There was a problem hiding this comment.
@alexjfisher his change look's good to me, can't see anything wrong with it.
So gonna go ahead and merge, thanks for putting the work in :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example for unit test taken from
https://stackoverflow.com/questions/1443816/convert-an-arbitrary-string-to-xml-in-ruby