Modernize escape functions

[smortex]

Quoting #1235 (comment)

What's with these functions using the old API?

Let's fix this!

[puppet-community-rangefinder]

batch_escape is a function

that may have no external impact to Forge modules.

powershell_escape is a function

that may have no external impact to Forge modules.

shell_escape is a function

Breaking changes to this file MAY impact these 6 modules (near match):

• bzed-dehydrated
• geoffwilliams-realmd
• puppet-poudriere
• glorpen-g_server
• puppet-mumble
• puppetlabs-kubernetes

batch_escape is a function

that may have no external impact to Forge modules.

powershell_escape is a function

that may have no external impact to Forge modules.

shell_escape is a function

Breaking changes to this file MAY impact these 6 modules (near match):

• bzed-dehydrated
• geoffwilliams-realmd
• puppet-poudriere
• glorpen-g_server
• puppet-mumble
• puppetlabs-kubernetes

This module is declared in 318 of 579 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[smortex]

Cc @alexjfisher

This is a quick test to check what needs to be done when modernizing a function. I am about to be AFK for a few weeks but will be happy to help migrate more functions when I am back 😉

[david22swan]

Changes LGTM
Thanks for the work :)