Simplify stdlib::manage#1250
Merged
chelnak merged 2 commits intopuppetlabs:mainfrom Jul 11, 2022
jcpunk:simplify-manage
Merged
Conversation
This should make the resources much less sensitive to parse order, since pupppet is already "doing the right thing" to Strings in this parameter location.
stdlib::manage is a classthat may have no external impact to Forge modules. This module is declared in 318 of 579 indexed public
|
petergmurphy
previously approved these changes
Jun 20, 2022
ekohl
requested changes
Jun 20, 2022
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
ekohl
approved these changes
Jun 20, 2022
Collaborator
ekohl
left a comment
There was a problem hiding this comment.
Code wise 👍 but I'm not sure what's up with the acceptance tests, but I also saw it in a different puppetlabs repo. Infrastructure issue?
chelnak
approved these changes
Jul 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make the resources much less sensitive to parse order,
since pupppet is already "doing the right thing" to Strings in this
parameter location.