Merged
Conversation
bastelfreak
reviewed
Oct 12, 2022
| @@ -1,4 +1,4 @@ | |||
| require 'puppet_x' | |||
| require_relative '../puppet_x' | |||
Collaborator
There was a problem hiding this comment.
is there maybe a rubocop rule we can use to enforce this?
Contributor
Author
There was a problem hiding this comment.
I've not seen one.. it would be cool if there was though. Even something to warn and say "maybe you should use require_relative here" would be nice.
bastelfreak
previously approved these changes
Oct 12, 2022
Prior to this commit using stdlib/to_toml function in a separate environment outside of production will result in the following error if the latest version doesn't also live in production: ``` Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Internal Server Error: org.jruby.exceptions.LoadError: (LoadError) no such file to load -- puppet_x/stdlib ``` This commit fixes the issue by updating code to use the correct paths for require_relative.
chelnak
force-pushed
the
CONT-200-fix_require_paths_for_puppet_x
branch
from
c29327c to
3312a18
Compare
pmcmaw
approved these changes
Oct 13, 2022
Contributor
pmcmaw
left a comment
pmcmaw
left a comment
There was a problem hiding this comment.
Failing tests are not in relation to this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR using stdlib/to_toml function in a separate environment outside of production will result in the following error if the latest version doesn't also live in production:
This PR fixes the issue by updating code to use the correct paths for require_relative.