Remove deprecated Private function#1310
Merged
LukasAud merged 1 commit intopuppetlabs:mainfrom Apr 24, 2023
Merged
Conversation
MartyEwings
requested review from
a team,
alexjfisher,
b4ldr,
bastelfreak,
ekohl and
smortex
as code owners
private is a functionthat may have no external impact to Forge modules. This module is declared in 318 of 580 indexed public
|
MartyEwings
force-pushed
the
remove_private
branch
from
93e5516 to
d98d334
Compare
alexjfisher
approved these changes
Apr 24, 2023
Collaborator
alexjfisher
left a comment
alexjfisher
left a comment
There was a problem hiding this comment.
I can't see how this could possibly be relevant anymore so LGTM.
LukasAud
approved these changes
Apr 24, 2023
Contributor
LukasAud
left a comment
LukasAud
left a comment
There was a problem hiding this comment.
Happy enough to merge. Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Private ceased to work in version of puppet greater than 3, and should be removed