Remove deprecated min function#1323
Merged
bastelfreak merged 1 commit intopuppetlabs:mainfrom Apr 26, 2023
Merged
Conversation
Contributor
MartyEwings
commented
Apr 25, 2023
MartyEwings
commented
MartyEwings
requested review from
a team,
alexjfisher,
b4ldr,
bastelfreak,
ekohl and
smortex
as code owners
min is a functionBreaking changes to this file MAY impact these 10 modules (near match):This module is declared in 318 of 580 indexed public
|
LukasAud
approved these changes
Apr 25, 2023
Contributor
LukasAud
left a comment
LukasAud
left a comment
There was a problem hiding this comment.
LGTM. Waiting for a second review.
smortex
approved these changes
Apr 25, 2023
bastelfreak
approved these changes
Apr 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.