Allow deferrable_epp to return a Sensitive[String]#1342
Merged
LukasAud merged 1 commit intopuppetlabs:mainfrom May 11, 2023
Merged
Allow deferrable_epp to return a Sensitive[String]#1342LukasAud merged 1 commit intopuppetlabs:mainfrom
deferrable_epp to return a Sensitive[String]#1342LukasAud merged 1 commit intopuppetlabs:mainfrom
Conversation
If none of the input variables are `Deferred`, then `deferrable_epp` returns the result of calling normal `epp`. The `epp` function however will return a `Sensitive` if any of the variables it was called with were `Sensitive`. See puppetlabs/puppet#8330 Adding `Sensitive[String]` to the list of allowed return types fixes this.
alexjfisher
requested review from
a team,
b4ldr,
bastelfreak,
ekohl and
smortex
as code owners
b4ldr
approved these changes
Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If none of the input variables are
Deferred, thendeferrable_eppreturns the result of calling normalepp.The
eppfunction however will return aSensitiveif any of the variables it was called with wereSensitive.See puppetlabs/puppet#8330
Adding
Sensitive[String]to the list of allowed return types fixes this.