Rewrite seeded_rand() as a Puppet 4.x function#1344
Merged
Conversation
Rather that testing that when called twice the function return the same or different values, test the actual returned value so that we are sure the behavior does not change unexpectedly.
The 3.x function rely on is_integer() which is deprecated. Rewrite it using the more modern puppet 4.x function to rely on data types for better parameters validation.
smortex
requested review from
a team,
alexjfisher,
b4ldr,
bastelfreak and
ekohl
as code owners
b4ldr
reviewed
Apr 28, 2023
binford2k
approved these changes
May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 3.x function rely on
is_integer()which is deprecated. Rewrite it using the more modern puppet 4.x function to rely on data types for better parameters validation.seeded_rand()as a Puppet 4.x function.