Fix validate_domain_name called without parameters#1351
Merged
Conversation
In #1345, the validate_domain_name() function was rewritten to the Puppet 4.x syntax, but the behaviour was slightly changed since we previously did not allow passing no parameter at all. Add code to assert as least one paramatter is passed to restore the previous behavior and raise an error when called without parameter.
smortex
requested review from
a team,
alexjfisher,
b4ldr,
bastelfreak and
ekohl
as code owners
validate_domain_name is a functionthat may have no external impact to Forge modules. This module is declared in 318 of 580 indexed public
|
binford2k
approved these changes
May 4, 2023
b4ldr
approved these changes
May 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1345, the
validate_domain_name()function was rewritten to thePuppet 4.x syntax, but the behavior was slightly changed since we
previously did not allow passing no parameter at all.
Add code to assert as least one parameter is passed to restore the
previous behavior and raise an error when called without parameter.