Conversation
Ramesh7
requested review from
a team,
alexjfisher,
b4ldr,
bastelfreak,
ekohl and
smortex
as code owners
Ramesh7
force-pushed
the
CONT-1023
branch
2 times, most recently
from
dea98f1 to
06bcac6
Compare
binford2k
previously approved these changes
May 30, 2023
smortex
reviewed
May 30, 2023
smortex
reviewed
May 30, 2023
Collaborator
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
This feels more more future proof to me, thanks! Only a minor fix and it's 💯 to me!
alexjfisher
reviewed
May 31, 2023
| # | ||
| # Output : ["value1", "value2.1"] | ||
| # | ||
| Puppet::Functions.create_function(:nested_values) do |
Collaborator
There was a problem hiding this comment.
What happened to all new functions being namespaced??
Collaborator
There was a problem hiding this comment.
Suggest namespacing it without creating a shim as this hasn't made it to a release yet.
Collaborator
There was a problem hiding this comment.
Damned! Yes, to all of this 😪
alexjfisher
reviewed
May 31, 2023
| describe 'nested_values' do | ||
| # please note that these tests are examples only | ||
| # you will need to replace the params and return value | ||
| # with your expectations |
Collaborator
There was a problem hiding this comment.
These comments should not have made it in.
alexjfisher
reviewed
May 31, 2023
| # frozen_string_literal: true | ||
|
|
||
| # This function will return list of Hash values, the return value will be Array | ||
| # NOTE : This function is expecting only Hash and return value will be Array |
Collaborator
There was a problem hiding this comment.
These two lines could be reworded to remove the repetition about the return value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Issue
Currently
stdlib::deferrable_eppdoesn't support well if the input variable is nested hash hasDeferrablevalue .Change
Adding support to evaluate the nested hash values to add support for nested hash.