Skip to content

Correct casing of Stdlib::IP::Address #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bastelfreak merged 1 commit into from
Nov 8, 2023
Merged

Correct casing of Stdlib::IP::Address #1406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion REFERENCE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5619,7 +5619,7 @@ Alias of `Pattern[/(?i:\Ahttps?:\/\/.*\z)/]`

Validate a host (FQDN or IP address)

Alias of `Variant[Stdlib::Fqdn, Stdlib::Ip::Address]`
Alias of `Variant[Stdlib::Fqdn, Stdlib::IP::Address]`

### <a name="Stdlib--Http--Method"></a>`Stdlib::Http::Method`

Expand Down
2 changes: 1 addition & 1 deletion types/host.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# @summary Validate a host (FQDN or IP address)
type Stdlib::Host = Variant[Stdlib::Fqdn, Stdlib::Ip::Address]
type Stdlib::Host = Variant[Stdlib::Fqdn, Stdlib::IP::Address]
Copy link
Copy Markdown
Collaborator Author

@ekohl ekohl Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now matches the casing here:

puppetlabs-stdlib/types/ip/address.pp

Line 2 in 883ba57

type Stdlib::IP::Address = Variant[

Copy link
Copy Markdown
Collaborator

@smortex smortex Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting 🤔. For some reason I stick to \A[[:upper:]][[:lower:]]*\z but it seems having more capital letters is valid… I guess what annoyed me is that I wanted to camel_case the type name for the file name as we do with Ruby but this is not supported…

Copy link
Copy Markdown
Collaborator Author

@ekohl ekohl Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that IP is a bit unusual, but this has been here for a while and sometimes being consistent is more important than other preferences.

⚡