Deprecate time function#1417
Merged
alexjfisher merged 1 commit intopuppetlabs:mainfrom Feb 14, 2024
Merged
Conversation
`time` was both an old API ruby function, and not needed since Puppet 4. In this commit, the `parser` function is removed and replaced by a non-namespaced APIv4 function. This is done to preserve compatibility before the function is removed completely in a later release. The ruby function calls a Puppet language function which implements the existing behaviour using core Puppet functionality. The original function did something weird with an optional `timezone` parameter. Nobody really remembers why. It appears that very early versions of Ruby may have been buggy and needed this as a workaround. To be clear, seconds since the epoch are the same _everywhere_. Timezone is not relevant.
alexjfisher
requested review from
a team,
b4ldr,
bastelfreak,
ekohl,
seanmil and
smortex
as code owners
bastelfreak
approved these changes
Feb 7, 2024
Collaborator
I'm not entirely sure this is true. I think epoch has a timezone, so the way it could work is that you set the local timezone (like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
timewas both an old API ruby function, and not needed since Puppet 4.In this commit, the
parserfunction is removed and replaced by a non-namespaced APIv4 function. This is done to preserve compatibility before the function is removed completely in a later release.The ruby function calls a Puppet language function which implements the existing behaviour using core Puppet functionality.
The original function did something weird with an optional
timezoneparameter. Nobody really remembers why. It appears that very early versions of Ruby may have been buggy and needed this as a workaround.To be clear, seconds since the epoch are the same everywhere. Timezone is not relevant.
Additional Context
Also see ad4ca4c
This also relates to #1260 as it removes another function completely from
lib/puppet/parser/functions.