delete_at added spec to check against bug #20681#183
Merged
adrienthebo merged 1 commit intopuppetlabs:masterfrom Sep 17, 2013
Merged
delete_at added spec to check against bug #20681#183adrienthebo merged 1 commit intopuppetlabs:masterfrom
adrienthebo merged 1 commit intopuppetlabs:masterfrom
Conversation
Contributor
|
Thank you very much for this contribution! The same comment goes for this as GH-182, could you update the commit message to match the following format? |
Contributor
Author
|
Thanks for the explanation. i will change that tomorrow! :-) |
The issue #20681 describe the error of delete() function removing the elements from the origin array/hash/string. This issue affected the other delete functions. The delete_at function is not afected by this bug, but it did not had the unit test to check against it. I had added the unit test so we could prevent regressions on the future and also have better test coverage.
Contributor
Author
|
updated as requested. |
adrienthebo
added a commit
that referenced
this pull request
Sep 17, 2013
delete_at added spec to check against bug #20681
Contributor
|
summary: merged into master in c2f584d; thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(#20681) delete_at function unit test against issue