Add rake tasks to validate and lint files and check with Travis#208
Merged
zaphod42 merged 1 commit intopuppetlabs:masterfrom Dec 18, 2013
Merged
Add rake tasks to validate and lint files and check with Travis#208zaphod42 merged 1 commit intopuppetlabs:masterfrom
zaphod42 merged 1 commit intopuppetlabs:masterfrom
Conversation
This patch adds the ability to validate syntax of manifests, templates, and ruby files in lib/ via `rake validate` and the linting of manifests with puppet-lint via `rake lint`. These two commands are chained with running the spec tests in Travis to ensure there are no syntax or style issues.
|
👍 I'm a big fan of setting up Travis catching litning issues. It might be worth considering the puppet-syntax gem as it has rake targets for manifest and erb validation. However, it would be another dep and doesn't have support for validating Ruby (shouldn't be hard to add). |
Contributor
Author
|
@jhoblitt I'll take a look at that. Can you merge this in meantime? I'm using it for my modules and it is working great and as you point out, does not need another dependency. |
|
@ghoneycutt I'm not a repo collab for this module. |
zaphod42
added a commit
that referenced
this pull request
Dec 18, 2013
Add rake tasks to validate and lint files and check with Travis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds the ability to validate syntax of manifests, templates,
and ruby files in lib/ via
rake validateand the linting of manifestswith puppet-lint via
rake lint. These two commands are chained withrunning the spec tests in Travis to ensure there are no syntax or style
issues.