Skip to content

(PUP-1459) Add support for root_home on OS X 10.9#215

Merged
zaphod42 merged 1 commit intopuppetlabs:masterfrom
blkperl:add_root_home_to_mavericks
Jan 28, 2014
Merged

(PUP-1459) Add support for root_home on OS X 10.9#215
zaphod42 merged 1 commit intopuppetlabs:masterfrom
blkperl:add_root_home_to_mavericks

Conversation

@blkperl
Copy link
Copy Markdown
Contributor

@blkperl blkperl commented Jan 17, 2014

getent does not exist on 10.9 so this commit uses
dscacheutil to query the homedir for the root user.

@blkperl
Copy link
Copy Markdown
Contributor Author

blkperl commented Jan 17, 2014

I tried to add a spec test but I got stuck on how to enable fixtures. Is there an easy way to do that? Looks like core facter has it's own functions in facter/spec/puppetlabs_spec to handle it.

@zaphod42
Copy link
Copy Markdown
Contributor

@blkperl the output of that command is short enough that I think you can just include it inline in the test.

@blkperl
Copy link
Copy Markdown
Contributor Author

blkperl commented Jan 21, 2014

@zaphod42 Tests added, figured out fixtures too

getent does not exist on 10.9 so this commit uses
dscacheutil to query the homedir for the root user.
zaphod42 added a commit that referenced this pull request Jan 28, 2014
(PUP-1459) Add support for root_home on OS X 10.9
@zaphod42 zaphod42 merged commit a2e9d00 into puppetlabs:master Jan 28, 2014
@blkperl blkperl deleted the add_root_home_to_mavericks branch January 28, 2014 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants