Add the missing shebangs and fix the wrong ones#248
Merged
hunner merged 1 commit intopuppetlabs:masterfrom May 7, 2014
averi:master
Merged
Add the missing shebangs and fix the wrong ones#248hunner merged 1 commit intopuppetlabs:masterfrom averi:master
hunner merged 1 commit intopuppetlabs:masterfrom
averi:master
Conversation
…omplaining loudly
Author
|
Would be also awesome if you could chmod +x all the .rb files, rpmlint is complaining about those as well. |
hunner
added a commit
that referenced
this pull request
May 7, 2014
Add the missing shebangs and fix the wrong ones
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm currently packaging puppetlabs-stdlib for Fedora / RHEL and rpmlint noticed several files missing shebangs. That resulted in many errors being thrown out and the impossibility for the package to be accepted into the official repositories.
It would be great if these changes could be reflected on the tarballs hosted at forge.puppetlabs.com, otherwise I can just rebase my work by creating a tarball from the master branch.
Thanks!