Make the range function work with integers

[dalen]

This is needed for the future parser which actually treats numbers as
numbers and strings as strings. With this patch you can use range(1,5)
instead of having to quote them like range('1','5').

Build on #364 which is just a style fix.

[daenney]

👍

[igalic]

nice

[jhoblitt]

I'd suggest adding coverage of a 3 parameters call with all integers.

As the function stands now, range([1,"10"]) would return a list of integers and range(["1",10]) would return a list of strings. I think it would probably be less surprising if mixed type parameters resulted in an exception.

[dalen]

I'll add more tests, but actually both range(1,"10") and range("1",10) return a list of integers.

Stuff like range('a', 10) return an empty array, just like range('a', '10') also did

[jhoblitt]

hmmm. I'm not sure why that's the behavior.

2.1.0 :001 > (1.to_i .. "10".to_i).step(1).collect { |i| i }
 => [1, 2, 3, 4, 5, 6, 7, 8, 9, 10] 

[dalen]

Not sure about which behavior?

On Wed, 12 Nov 2014 18:28 Joshua Hoblitt notifications@github.com wrote:

hmmm. I'm not sure why that's the behavior.

2.1.0 :001 > (1.to_i .. "10".to_i).step(1).collect { |i| i }
=> [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]

—
Reply to this email directly or view it on GitHub
#365 (comment)
.