Skip to content

Need to convert strings and fixnums to arrays#367

Merged
cmurphy merged 1 commit intopuppetlabs:masterfrom
underscorgan:future_parser_fix
Nov 17, 2014
Merged

Need to convert strings and fixnums to arrays#367
cmurphy merged 1 commit intopuppetlabs:masterfrom
underscorgan:future_parser_fix

Conversation

@underscorgan
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread lib/puppet/parser/functions/member.rb Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line of documentation is now out of date:
The variable can either be a string or an array.

Also, it might be useful to raise when a string, number or array isn't passed as the second argument (what happens when a hash is passed, or undef (is it represented as a symbol)?

Comment thread lib/puppet/parser/functions/member.rb Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"either" implies one of two, should just be "The variable can be a string, fixnum, or array.")

cmurphy added a commit that referenced this pull request Nov 17, 2014
Need to convert strings and fixnums to arrays
@cmurphy cmurphy merged commit 72ee9b5 into puppetlabs:master Nov 17, 2014
@underscorgan underscorgan deleted the future_parser_fix branch November 17, 2014 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants