Basename implementation#368
Merged
underscorgan merged 1 commit intopuppetlabs:masterfrom Dec 17, 2014
rfugina:basename
Merged
Conversation
|
👍 Looks good. |
|
Actually, probably needs some type checking to be future parser safe. |
Contributor
Author
|
That's it, should be good. |
Contributor
Author
|
Type checking has been added (and I did the same for the 'dirname' function -- different pull request). |
Contributor
There was a problem hiding this comment.
This should include Type: rvalue
Contributor
There was a problem hiding this comment.
Also, maybe some more explicit examples? just to be very verbose?
Contributor
|
@rfugina this looks good in general! I made two comments on your README updates, and other than that if you could squash this down to a single commit then we can merge it! 👍 |
This was referenced Dec 17, 2014
Closed
Based on dirname code. Includes RSpec tests and docs.
Contributor
Author
|
Squashed. Also made the other changes you requested, but the commits/comments got squashed away. |
Contributor
|
\o/ thanks @rfugina! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used dirname function as a model. Wraps Ruby's File.basename in similar fashion. Docs included. RSpec tests included, and pass. Github says "able to merge".