Adding markdown for the range() function's 3rd argument#410
Merged
underscorgan merged 1 commit intopuppetlabs:masterfrom Mar 4, 2015
Merged
Adding markdown for the range() function's 3rd argument#410underscorgan merged 1 commit intopuppetlabs:masterfrom
underscorgan merged 1 commit intopuppetlabs:masterfrom
Conversation
Contributor
|
👍 |
Contributor
|
Hi @robruma, thanks for the contribution! Could you rebase this against master so it only contains the one commit with your changes? Thanks! |
Contributor
Author
|
@mhaskel Hopefully this is what you expected, please let me know if you'd rather me squash all the changes... Thanks |
Contributor
|
@robruma We'd like this to be a squashed down to a single commit before we merge it (and it shouldn't have all the merge commits it has now) |
Adding markdown for the range() function's 3rd argument Adding markdown for the range() function's 3rd argument
robruma
force-pushed
the
range_documentation_update
branch
from
3b9fb8a to
380cb02
Compare
Contributor
Author
|
@mhaskel sorry for the delay, hopefully this commit is satisfactory. Thanks |
underscorgan
pushed a commit
that referenced
this pull request
Mar 4, 2015
Adding markdown for the range() function's 3rd argument
Contributor
|
Looks good, thanks @robruma ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This documents the feature added in #56