Skip to content

Fix issue with 1.8.7 and upcase #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
underscorgan merged 1 commit into from
Feb 26, 2015
Merged

Fix issue with 1.8.7 and upcase #418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/puppet/parser/functions/upcase.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ module Puppet::Parser::Functions
result = value.collect { |i| i.is_a?(String) ? i.upcase : i }
elsif value.is_a?(Hash)
result = {}
result << value.each_pair do |k, v|
return {k.upcase => v.collect! { |p| p.upcase }}
value.each_pair do |k, v|
result.merge!({k.upcase => v.collect! { |p| p.upcase }})
Copy link
Copy Markdown
Contributor

@elyscape elyscape Feb 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not instead do:

result[k.upcase] = v.collect { |p| p.upcase}

This results in significantly object creations.

Additionally, this will fail if v is a nested array or a hash.

end
else
result = value.upcase
Expand Down
⚡