Skip to content

adding support for hash in the size function#489

Merged
DavidS merged 1 commit intopuppetlabs:masterfrom
gcmalloc:master
Jul 22, 2015
Merged

adding support for hash in the size function#489
DavidS merged 1 commit intopuppetlabs:masterfrom
gcmalloc:master

Conversation

@gcmalloc
Copy link
Copy Markdown
Contributor

No description provided.

@gcmalloc gcmalloc closed this Jul 21, 2015
Comment thread spec/functions/size_spec.rb Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of them should read and_return(0)

@DavidS DavidS reopened this Jul 22, 2015
@DavidS
Copy link
Copy Markdown
Contributor

DavidS commented Jul 22, 2015

Hi @gcmalloc,

I like this change and it only needs some small changes to get it ship shape. Please use git commit --amend this change so it stays a single commit and force push it to this PR.

Thanks for your time and work!

@gcmalloc
Copy link
Copy Markdown
Contributor Author

Thanks for the kindness !

DavidS added a commit that referenced this pull request Jul 22, 2015
adding support for hash in the size function
@DavidS DavidS merged commit dca8bdb into puppetlabs:master Jul 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants