[#puppethack] Adding replace attribute to file_line#494
Merged
bmjen merged 1 commit intopuppetlabs:masterfrom Jul 30, 2015
Merged
[#puppethack] Adding replace attribute to file_line#494bmjen merged 1 commit intopuppetlabs:masterfrom
bmjen merged 1 commit intopuppetlabs:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
If match_regex returns nil... this will result in a NoMethodError
Contributor
There was a problem hiding this comment.
On second look, given this code path, you should be able to assume that match_regex is not nil.
Contributor
Author
There was a problem hiding this comment.
Yeah, the handle_create_with_match function will not be used to write the line unless resource[:match] is not nil. So the creation of the regex that match_regex returns should not fail in this block.
Contributor
Author
There was a problem hiding this comment.
it also isn't a new behavior with this patch. The line only changes because where the Regexp is created is moved and renamed from regex to match_regex
bmjen
added a commit
that referenced
this pull request
Jul 30, 2015
[#puppethack] Adding replace attribute to file_line
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding tests and minor changes to make @WhatsARanjit's PR #451 work.
The patch adds the optional
replaceattribute to file_line. It defaults to true, which maintains current behavior. Setting the attribute to false will allow users to ensure that a line matching thematchattribute exists without overwriting it with the contents oflineif the matching lines exists