Fix load module metadata#537
Merged
DavidS merged 2 commits intopuppetlabs:masterfrom Oct 15, 2015
Merged
Conversation
`rake spec` only finds test files that end in _spec.rb, so this test was not being run. Correct the path name so that the test runs properly.
Some modules or module versions don't have a metadata.json file, but we might still want to use the load_module_metadata function on them. The lack of a file can still give us important information. For example, it might tell us that the version of the module installed is "very old" even if we can't read the version number directly. This patch adds a parameter to let the user specify if an empty file is acceptable. To preserve backwards compatibility it does not change the current default behavior, which is to raise an error if metadata.json does not exist.
Contributor
Author
|
ping @nibalizer |
Contributor
|
Thanks for your contribution, Colleen! |
Contributor
Author
|
Thanks @DavidS! When do you think this might get released? ;) |
Contributor
|
Nice! |
Contributor
|
There is currently no release planned. Until there is one, you can use a reference to github in your Puppetfile to get this version. ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix spec test and add feature to allow absence of metadata.json.