add functionality to bool2str function#538
Merged
DavidS merged 1 commit intopuppetlabs:masterfrom Oct 16, 2015
Merged
Conversation
Contributor
|
bool2str is already of questionable value, given that it basically implements That said, I would still merge this as it has good docs and tests, if you change the array to two separate parameters. That's another two keystrokes saved. |
366ccfc to
6de1a6e
Compare
Contributor
Author
|
@DavidS I concur on the usefulness of the old bool2str. Hopefully this will make it more useful because there's been plenty of times where I've done something like I've updated and squashed my code so it doesn't use an array any more. |
DavidS
added a commit
that referenced
this pull request
Oct 16, 2015
add functionality to bool2str function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bool2str function already exists and converts a boolean true/false to a string true/false. It is not documented in the README.
There are cases when something expects a boolean value to be something other than true/false, such as yes/no, t/f, Yes/No, on/off, etc.
This pull request add an optional two element array that bool2str will accept and convert the boolean true/false to the corresponding value in the array. If no array is given, it converts boolean true/false to a string true/false (which also preserves backwards compatibility).
Examples: