use properly encoded characters#542
Merged
HelenCampbell merged 1 commit intopuppetlabs:masterfrom Nov 6, 2015
Merged
Conversation
This is more severe than it sounds. These characters make puppet fail with the following message : > Error 400 on SERVER: "\xC3" on US-ASCII
HelenCampbell
pushed a commit
that referenced
this pull request
Nov 6, 2015
use properly encoded characters
Contributor
|
Thank you :) |
Contributor
|
really? if i put my own name (Galić) in .pp files it fails with the same reason. but then again, é is in US-ASCII, ć is not… |
Contributor
Author
|
Yeah, I don't know why US-ASCII is being use here rather than utf-8… |
Contributor
|
bizarrely, it's the ruby default, starting 1.9, unless you tell it to use unicode… |
Contributor
Author
Guess this is what actually needs to be fixed… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more severe than it sounds. These characters make puppet fail with the following message :