Add clamp function

[mpolenchuk]

Clamp keeps value within the range.
Employ of soft() makes the whole thing is independant of order.

[tphoney]

This would also need a readme update. Thanks for the work.

[mpolenchuk]

Done

[tphoney]

Thanks for the quick response 👍

So reading your implementations of clamp i would prefer the parameter ordering of: value, min, max
rather than min, value, max.

I think the function should be limited to 3 values, and not allowing arrays.

[mpolenchuk]

Actually the order of params doesn't matter, it could be [max, min, value] or [max, value, min] or ... whatever.
Function technically limited to 3, but it provides flexible input: get arrays, strings as numerics and numerics itself. This was done intentionally.

[mpolenchuk]

In other words you might have $range = [minLimit, maxLimit] and valueX.
Just call clamp($range, valueX) and get value within the range.

[mpolenchuk]

Bump

[DavidS]

couldn't this just be args = args.flatten ?

[mpolenchuk]

yes, thanx

[DavidS]

Hi Michael, I added a few comments on issues with the code. I think the overall idea of the clamp function is great, but the code does need a bit work. Especially with the move of puppet 4 to more conscious and strict typing, please reconsider your plan to allow arbitrary arrays and strings as arguments. I would much prefer a more strict signature like tp suggested, that does just take three ints.

[mpolenchuk]

Hi David, thank you for the feedback. I've fixed issues w/ the code.

[DavidS]

Thanks for your work, @mpolenchuk !