Ensure validate functions use Puppet 4 deprecation#654
Merged
DavidS merged 1 commit intopuppetlabs:masterfrom Sep 21, 2016
Merged
Ensure validate functions use Puppet 4 deprecation#654DavidS merged 1 commit intopuppetlabs:masterfrom
DavidS merged 1 commit intopuppetlabs:masterfrom
Conversation
HelenCampbell
force-pushed
the
puppet4Dep
branch
5 times, most recently
from
463fd5d to
e6a926d
Compare
HelenCampbell
force-pushed
the
puppet4Dep
branch
from
e6a926d to
0ec7ffa
Compare
Collaborator
|
@DavidS @HelenCampbell Since this PR was merged, builds have started failing. eg https://travis-ci.org/voxpupuli/puppet-rundeck/jobs/161638419#L1281 Thing is, line 241 of init.pp is a call to |
Contributor
Author
|
@alexjfisher Thank you for catching this. Since I've looked in to it I'm not sure the solution is simple. I've created a PR to revert and I'll create a ticket to look in to this. Thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.