Skip to content

Fix unsupported data type error with rspec-puppet master#715

Merged
DavidS merged 1 commit intopuppetlabs:masterfrom
domcleal:function-fact-freeze
Feb 20, 2017
Merged

Fix unsupported data type error with rspec-puppet master#715
DavidS merged 1 commit intopuppetlabs:masterfrom
domcleal:function-fact-freeze

Conversation

@domcleal
Copy link
Copy Markdown
Contributor

@domcleal domcleal commented Feb 3, 2017

The symbol used in the value of the facts hash is not a valid type of
value for facts, and results in the following error since
rspec-puppet@d50acf0e.

Puppet::Error:
  Unsupported data type: 'Symbol'
# puppet/lib/puppet/parser/scope.rb:788:in `deep_freeze'
# puppet/lib/puppet/parser/scope.rb:781:in `block in deep_freeze'
# puppet/lib/puppet/parser/scope.rb:781:in `each'
# puppet/lib/puppet/parser/scope.rb:781:in `deep_freeze'
# puppet/lib/puppet/parser/scope.rb:764:in `set_facts'
# puppet/lib/puppet/parser/compiler.rb:850:in `set_node_parameters'
# puppet/lib/puppet/parser/compiler.rb:166:in `block (2 levels) in compile'
# puppet/lib/puppet/util/profiler/around_profiler.rb:58:in `profile'
# puppet/lib/puppet/util/profiler.rb:51:in `profile'
# puppet/lib/puppet/parser/compiler.rb:166:in `block in compile'
# puppet/lib/puppet/context.rb:65:in `override'
# puppet/lib/puppet.rb:293:in `override'
# puppet/lib/puppet/parser/compiler.rb:162:in `compile'
# rspec-puppet/lib/rspec-puppet/example/function_example_group.rb:161:in `build_compiler'

The fact's presence doesn't change the behaviour, so remove it.

@domcleal domcleal force-pushed the function-fact-freeze branch from 6a47e81 to c8c9ee6 Compare February 4, 2017 09:24
The symbol used in the value of the facts hash is not a valid type of
value for facts, and results in the following error since
rspec-puppet@d50acf0e.

    Puppet::Error:
      Unsupported data type: 'Symbol'
    # puppet/lib/puppet/parser/scope.rb:788:in `deep_freeze'
    # puppet/lib/puppet/parser/scope.rb:781:in `block in deep_freeze'
    # puppet/lib/puppet/parser/scope.rb:781:in `each'
    # puppet/lib/puppet/parser/scope.rb:781:in `deep_freeze'
    # puppet/lib/puppet/parser/scope.rb:764:in `set_facts'
    # puppet/lib/puppet/parser/compiler.rb:850:in `set_node_parameters'
    # puppet/lib/puppet/parser/compiler.rb:166:in `block (2 levels) in compile'
    # puppet/lib/puppet/util/profiler/around_profiler.rb:58:in `profile'
    # puppet/lib/puppet/util/profiler.rb:51:in `profile'
    # puppet/lib/puppet/parser/compiler.rb:166:in `block in compile'
    # puppet/lib/puppet/context.rb:65:in `override'
    # puppet/lib/puppet.rb:293:in `override'
    # puppet/lib/puppet/parser/compiler.rb:162:in `compile'
    # rspec-puppet/lib/rspec-puppet/example/function_example_group.rb:161:in `build_compiler'

The fact's presence doesn't change the behaviour, so remove it.
@domcleal domcleal force-pushed the function-fact-freeze branch from c8c9ee6 to 89a36c6 Compare February 4, 2017 09:24
@DavidS DavidS merged commit e64a9d6 into puppetlabs:master Feb 20, 2017
@DavidS
Copy link
Copy Markdown
Contributor

DavidS commented Feb 20, 2017

Merging on red acceptance, since it is a unit test only change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants