Add new file_line option append_on_no_match#717
Merged
eputnam merged 1 commit intopuppetlabs:masterfrom Jul 26, 2017
Merged
Conversation
Contributor
|
@ripclawffb There have been a number of changes in the file_line can you see if this PR is still necessary. More importantly apologies for the slowness to getting to this PR |
310fb93 to
0263b06
Compare
Contributor
Author
|
@tphoney I reviewed the changes for file_line and there still doesn't seem to be an option to not add a line if a match is not found in a file. I also went ahead and rebased as requested. |
Contributor
|
rebased again @tphoney, looks ok pending travis. @ripclawffb take a look if you'd like to make sure it still looks ok to you. |
Contributor
Author
|
@eputnam thanks! looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there doesn't exist a way to leave a file untouched if no regex matches are found.
I have a use case where I'm searching for a specific regex in multiple files and I only want to update the files that contain the regex pattern.