(MODULES-4528) Use versioncmp to check Puppet version for 4.10.x compat#737
Merged
wilson208 merged 1 commit intopuppetlabs:masterfrom Mar 16, 2017
Merged
(MODULES-4528) Use versioncmp to check Puppet version for 4.10.x compat#737wilson208 merged 1 commit intopuppetlabs:masterfrom
wilson208 merged 1 commit intopuppetlabs:masterfrom
Conversation
`Puppet.version.to_f` on Puppet 4.10.0 will evaluate to `4.1`, causing test and behavioural changes when conditionals check that the version is equal or greater than versions such as `4.3`. Version comparisons that are vulnerable to this have been changed to use Puppet's versioncmp implementation, while most others only check for for major version boundaries which is safe.
wilson208
approved these changes
Mar 16, 2017
Contributor
|
👍 LGTM, Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Puppet.version.to_fon Puppet 4.10.0 will evaluate to4.1, causingtest and behavioural changes when conditionals check that the version is
equal or greater than versions such as
4.3.Version comparisons that are vulnerable to this have been changed to use
Puppet's versioncmp implementation, while most others only check for
for major version boundaries which is safe.