Skip to content

Add support for a 'match' parameter to file_line#75

Merged
jeffmccune merged 1 commit intopuppetlabs:masterfrom
cprice404:feature/master/regex-support-for-file-line
Jun 11, 2012
Merged

Add support for a 'match' parameter to file_line#75
jeffmccune merged 1 commit intopuppetlabs:masterfrom
cprice404:feature/master/regex-support-for-file-line

Conversation

@cprice404
Copy link
Copy Markdown

This commit adds a new parameter called "match"
to the file_line resource type, and support for
this new parameter to the corresponding ruby
provider.

This parameter is optional; file_line should work
just as before if you do not specify this parameter...
so this change should be backwards-compatible.

If you do specify the parameter, it is treated
as a regular expression that should be used when
looking through the file for a line. This allows
you to do things like find a line that begins with
a certain prefix (e.g., "foo=."), and *replace
the existing line with the line you specify in your
"line" parameter. Without this capability, if you
already had a line "foo=bar" in your file and your
"line" parameter was set to "foo=baz", you'd end up
with both lines in the final file. In many cases
this is undesirable.

This commit adds a new parameter called "match"
to the file_line resource type, and support for
this new parameter to the corresponding ruby
provider.

This parameter is optional; file_line should work
just as before if you do not specify this parameter...
so this change should be backwards-compatible.

If you do specify the parameter, it is treated
as a regular expression that should be used when
looking through the file for a line.  This allows
you to do things like find a line that begins with
a certain prefix (e.g., "foo=.*"), and *replace*
the existing line with the line you specify in your
"line" parameter.  Without this capability, if you
already had a line "foo=bar" in your file and your
"line" parameter was set to "foo=baz", you'd end up
with *both* lines in the final file.  In many cases
this is undesirable.
@cprice404
Copy link
Copy Markdown
Author

This is a prerequisite for the postgres module that I'm working on. Would love to get a quick review from any or all of @jeffmccune , @glarizza , @rcoleman , @nanliu , @bodepd

jeffmccune pushed a commit that referenced this pull request Jun 11, 2012
…t-for-file-line

Add support for a 'match' parameter to file_line
@jeffmccune jeffmccune merged commit e299ac6 into puppetlabs:master Jun 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants